Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] JavaScriptImportScanner should resolve packages *async* and should use the analyzer's loader, not fs. #316

Closed
usergenic opened this issue May 3, 2018 · 2 comments
Labels

Comments

@usergenic
Copy link
Contributor

It is not possible to run analyzer with moduleResolution: 'node' with a virtual filesystem (i.e. using a loader that draws file contents from some other places than standard local filesystem.)

First obstacle to this is that the resolve calls are using the synchronous version, i.e. require('resolve').sync(). We need to convert this to use the async version of the resolver and then we should find a way to plug-in the analyzer's loader to return the various package.json files that are requested during the resolution steps.

justinfagnani pushed a commit that referenced this issue Jul 10, 2018
@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant