polymer-bundler v3.1.1 fails to inline script with empty getter function

[freshp86]

bug.html file

<script src="bug.js"></script>

bug.js file

class Foo {
  get foo() {}
}

Polymer bundler command (version 3.1.1)

./node_modules/polymer-bundler/lib/bin/polymer-bundler.js --in-html bug.html --inline-scripts --manifest-out manifest.json

The command above returns the contents of the original HTML file without inlining the JS file. The contents of the manifest indicate that something went wrong.

{"bug.html":["bug.html"],"_missing":["bug.js"]}

Apparently polymer-bundler failed to find the JS file, which seems very odd.

If get foo() {} is changed to have some contents, like

get foo {
  console.log('foo');
}

The problem no longer happens, and the script is inlined as expected.

[freshp86]

cc @azakus @usergenic. This was discovered at https://chromium-review.googlesource.com/c/chromium/src/+/1309223 by @rbp314.

[usergenic]

Interesting... i wonder if our JS parser in the analyzer broke trying to read it with empty body and/or if this is an issue with latest package versions. Thanks for the heads up @freshp86 - I'll add a regression test for this case and see where it leads.

[usergenic]

Note Bundler is now part of https://github.com/Polymer/tools so I'll transfer this issue over there.

[moderndeveloperllc]

@usergenic Issue with dead code removal? Just a thought. Seen lots of those floating around babel repos lately for some reason.

[usergenic]

@moderndeveloperllc makes a lot of sense assuming the dead-code removal occurs prior to bundling. Verifying...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!