Disable deadcode removal in babel-minify #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad codepath evaluation removing needed expected code.
|
There are 3 open issues with deadcode removal that may or may not be directly contributing here, but more importantly, until we can fully rely on deadcode removal behavior, I think we should disable this optimization. |
rictic
approved these changes
Nov 5, 2018
packages/build/src/js-transform.ts
Outdated
| @@ -98,14 +98,20 @@ const babelSyntaxPlugins = [ | |||
| ]; | |||
|
|
|||
| const babelPresetMinify = require('babel-preset-minify')({}, { | |||
| // Disable the minify-constant-folding plugin because it has a bug relating to | |||
| // Disable the minify-constant-folding plugin because it has a bug relating | |||
| // to | |||
|
@usergenic Does this also solve #775? |
|
@moderndeveloperllc I was not able to replicate that problem with current version of bundler. Solving for the 3.x branch may be possible but I've not yet identified what's causing it. |
|
(edited: "I was not able to replicate") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #724 where deadcode removal in babel-minify can be error prone and result in removal of code which should not be removed and cause hard to debug errors.