Add integration test of import.meta support and improve test robustness. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pulls in a subset of #308 |
TimvdLippe
reviewed
May 3, 2018
| @@ -249,7 +270,7 @@ suite('integration tests', function() { | |||
| })); | |||
| }); | |||
|
|
|||
| test('test the lit-element "shop" template', async function() { | |||
| test.only('test the lit-element "shop" template', async function() { | |||
There was a problem hiding this comment.
Make sure to remove this before merging ;)
This reverts commit 8df99a8.
|
The es5-bundled build is failing with a regeneratorRuntime error, so we need to filter it out until https://github.com/Polymer/polymer-cli/issues/1000 is fixed. See: https://ci.appveyor.com/project/Polymer/tools/build/1.0.872 |
rictic
changed the title
|
#308 was accidentally merged into this branch by PolymerLabs/project-health#509 |
aomarks
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.