Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable editor-service tests #342

Closed
wants to merge 1 commit into from
Closed

Re-enable editor-service tests #342

wants to merge 1 commit into from

Conversation

TimvdLippe
Copy link
Contributor

I was not able to let them fail locally, so let's see what CI says.

Fixes #170

@TimvdLippe TimvdLippe requested a review from rictic May 6, 2018 14:54
@TimvdLippe
Copy link
Contributor Author

Build is failing on wct, but not these tests:

Browser Tests integration fixture dir 'custom-components_dir' "before all" hook:
lerna ERR! lerna      Error: Timeout of 90000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@rictic
Copy link
Contributor

rictic commented May 7, 2018

It's only very occasionally flaky. We might have turned on retries here though, in which case this should be fine.

@TimvdLippe
Copy link
Contributor Author

Superseded by #429

@TimvdLippe TimvdLippe closed this Jun 15, 2018
@TimvdLippe TimvdLippe deleted the reenable-editor-service-tests branch June 15, 2018 13:04
justinfagnani pushed a commit that referenced this pull request Jul 10, 2018
@FredKSchott
[README] Add conversion options, update documentation a bit (#342)
385b93b 
* Update README to include info on conversion options

* Update README.md

* respond to feedback
This was referenced Nov 25, 2020
Open
Open
This was referenced Sep 15, 2021
Open
Open
@Exnadella Exnadella mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rictic rictic Awaiting requested review from rictic

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimvdLippe @rictic @googlebot