[polymer-build] Added wct-mocha to the list of supported WCT client-side packages in the html-transform. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the html-transform.
|
I should add that I totally hate that this WCT + esm-amd-loader collaboration hack is happening inside of polymer-build. |
aomarks
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WCT to work properly with the esm-amd-loader, polymer-build adds a little hack where it waits for all defined modules to resolve before calling the original WCT waitFor callback. That hack is only added when there is a recognized WCT client-side package. Previously
web-component-tester/browser.jsorwct-browser-legacy/browser.js. This PR just addswct-mocha/browser.jsto that list.