Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-header-layout should respect header's scrollTarget #547

Open
1 task done
bennypowers opened this issue Apr 23, 2018 · 0 comments
Open
1 task done

app-header-layout should respect header's scrollTarget #547

bennypowers opened this issue Apr 23, 2018 · 0 comments

Comments

@bennypowers
Copy link

Description

<app-header-layout> clobbers it's header's scrollTarget in _updateLayoutStates

Expected outcome

If scrollTarget is set on header, it should be respected

Actual outcome

scrollTarget is reset to either documentElement or contentContainer

Live Demo

https://jsbin.com/wusagubagi/1/edit?html,js,console

Steps to reproduce

  1. Put a app-header-layout element in the page with an app-header.
  • set the app-header scrollTarget property.
  • scrollTarget is reset by app-header-layout.

Browsers Affected

  • Chrome
  • [ x] Firefox
  • [ x] Safari 9
  • [ x] Safari 8
  • [x ] Safari 7
  • [x ] Edge
  • [x ] IE 11
  • [x ] IE 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant