Create background layers lazyly #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
force-pushed
the
header-lazy-dom
branch
2 times, most recently
from
764380a
to
45a8bf8
Compare
blasten
force-pushed
the
header-lazy-dom
branch
2 times, most recently
from
15a28ff
to
86b251b
Compare
blasten
force-pushed
the
header-lazy-dom
branch
3 times, most recently
from
6a103d5
to
353a8a9
Compare
| var title = Polymer.dom(this).querySelector('[title]'); | ||
| var condensedTitle = Polymer.dom(this).querySelector('[condensed-title]'); | ||
| var title = this._getDOMRef('title'); | ||
| var condensedTitle = this._getDOMRef('condensedTitle'); |
There was a problem hiding this comment.
This will create _bgContainer and I don't think is needed for resize-title effect.
added 9 commits
May 26, 2016 14:57
|
LGTM |
This was referenced May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An approach to #183, and also cleans up the API without breaking anything.