-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cases when app-drawer is appended later #313
Conversation
Actually, this will cause more work if app-drawer is already attached during init - need to revisit |
We might want to handle for the case when app-drawer is upgraded (e.g. lazy import) later. |
@frankiefu Does lazy import mean the custom |
Yeah. Just tried out one of the app-drawer-layout demo and noticed couple things:
|
LGTM |
Hello! I'm currently having this issue using Polymer 2, though it says here it's been resolved. I updated my dependencies, but the issue persists. |
This is resulting in the drawer not resetting, so things like
don't work properly. The drawer stays open on page changes. |
Might fix #273