-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0-preview branch #64
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ed6b40b
Initial changes for 2.0
bicknellr 9448587
update paper-styles dependency, `@apply` syntax
bicknellr 85fa874
remove dom-bind
bicknellr d294172
Add 1.x variant; update iron-component-page dependency.
bicknellr 1b769ec
Add all dependencies to 1.x variant.
bicknellr 799666b
bower update
0fcf558
auto-generated: update repo for v2
tedium-bot d0dfaac
Merge pull request #70 from PolymerElements/_auto_generated_v2_preview
notwaldorf 08d646d
Update dependencies.
bicknellr bfd36eb
Point to Polymer 2.0 RC 1
tedium-bot d1d37e1
Update travis config
tedium-bot 42b6948
Merge pull request #72 from PolymerElements/auto-cleanup
e111077 f50d377
update .gitignore
bicknellr 2880bd7
Convert manually constructed DOM back to HTML.
bicknellr 7c7a5db
Don't chain assignments.
bicknellr 2a9b411
Merge remote-tracking branch 'origin/master' into 2.0-preview
bicknellr 5e6b568
update README.md
bicknellr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
util/node_modules | ||
material-design-icons | ||
bower_components | ||
bower_components* | ||
bower-*.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,27 @@ | ||
language: node_js | ||
sudo: required | ||
before_script: | ||
- npm install -g bower polylint web-component-tester | ||
- bower install | ||
- polylint | ||
- npm install -g bower polymer-cli@next | ||
- polymer install --variants | ||
- sudo mv /usr/bin/google-chrome /usr/bin/google-chrome-old | ||
- sudo mv /usr/bin/google-chrome-beta /usr/bin/google-chrome | ||
env: | ||
global: | ||
- secure: >- | ||
L3XJmmXJlYZYyvlKoZ25HpEC1FcTtWejNk2xRQKAH4cg8+oNMjE80OxkaIVHtZlatpLdIIYk79p+9OtGiskXZ1QsAjHtrxWE5YRSSz3nL/XyZqUu7tjiNtrih6PiEvocmwMCCdRGMSXwVl1YoUUYM0DWxHdykd0EMXYYkYe+yQo= | ||
- secure: >- | ||
PSLkHUoiTj6UxN+7KtZG2miLmeuDuGN4c+ksviIP4/4lh5x7xic7CIeMmf2HLd18MR8CwCHjfMrIrxYF/IusILn6fdQ8rdBw+XhEF7xP+8UqqgF6YjGHs/xPDYYiGtisEc2OOg+vzqXIMhmKTg2vVlhuNq16eggGsRDcsEhEong= | ||
node_js: '6' | ||
node_js: stable | ||
addons: | ||
firefox: latest | ||
apt: | ||
sources: | ||
- google-chrome | ||
packages: | ||
- google-chrome-stable | ||
- google-chrome-beta | ||
script: | ||
- true || xvfb-run wct | ||
- 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then true || wct -s ''default''; fi' | ||
- true || xvfb-run polymer test | ||
- >- | ||
if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then true || polymer test -s | ||
'default'; fi | ||
dist: trusty |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the whole demo have to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. doesn't work anymore because
list
is no longer an observable property. Also, having the extra<dom-repeat>
around the repeated items kind of screws up styling them since they're meant to flex anddisplay: contents;
doesn't actually work yet. The easiest way to handle this seemed to be to generate the DOM manually but I'm not attached to that method if you've got other recommendations. I tried changing it so that the<dom-repeat>
elements were used for display instead of wrapping with divs but this seems to trigger a ShadyCSS problem that prevents all the styles on the page from being rewritten properly. I'll keep trying to revert this but the ShadyCSS thing is blocking it for now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr of @notwaldorf offline: 'wat, no'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
list
part makes sense and thevar iconsets
line makes sense. The constructing a 💩 ton of DOM seems silly and let's maybe not do that :)