Enable _removeListener after Polymer/polymer#1740 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymer/polymer#1740 adds `unlisten` functionality, thus fixing blocking issue Polymer/polymer#1639. Now `iron-selector` can properly remove the event listener for the old activate event when it is changed instead of being forced to ignore unwanted calls handler calls.
|
That API hasn't landed in a release yet. Wait for Polymer 1.0.4. |
|
Ah! Didn't even notice. Should I just leave this up until then? |
|
LGTM! cc @notwaldorf @frankiefu |
Closed
This was referenced Sep 8, 2015
|
LGTM2. |
blasten
added a commit
that referenced
this pull request
Sep 12, 2015
Enable _removeListener after Polymer/polymer#1740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymer/polymer#1740 adds
unlistenfunctionality, thus fixing blocking issue Polymer/polymer#1639. Nowiron-selectorcan properly remove the event listener for the old activate event when it is changed instead of being forced to ignore unwanted handler calls.