Remove deprecated neon animation, use CSS keyframe animations #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove neon-animation dependency in favor of CSS keyframe animations, taking a similar approach as in PolymerElements/iron-dropdown#154 and PolymerElements/paper-dialog#163.
The expand/collapse animation is done in a performant way using
transform, which doesn't cause layout thrashing - more details here https://medium.com/@valdrinkoshi/performant-expand-collapse-animations-93d99e80f7fThe properties
openAnimationConfigandcloseAnimationConfigare now deprecated, aspaper-menu-buttoncannot really allow users to define animations for its internaliron-dropdown, as there is no way to pass@keyframesinto its shadowRoot. Because of this,paper-menu-buttondoesn't offer a way to customize open/close animations :[Nevertheless, after testing this on internal projects it doesn't break them - as most of them rely on the default animations setup by paper-menu-button.
This PR depends on PolymerElements/iron-dropdown#154.