Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Latest dependencies #31

Merged
merged 4 commits into from
May 27, 2015
Merged

Latest dependencies #31

merged 4 commits into from
May 27, 2015

Conversation

jeffposnick
Copy link
Contributor

R: @addyosmani @wibblymat

Will tag this as the v0.9.0 release after it's merged.

@wibblymat
Copy link
Contributor

I don't see any errors, but neither the docs nor the demo render any content. Not really sure what's going on. I tried deleting the bower_components folder and starting again, as well as clearing the SW cache and unregistering the SW.

@wibblymat
Copy link
Contributor

Tests pass though, which is weird.

@jeffposnick
Copy link
Contributor Author

The demo works for me, but not the docs. I'm seeing the same doc-related error with other components, though, e.g. paper-toast:

image

I took the fact that the tests passed as a good sign.

@mbleigh
Copy link
Contributor

mbleigh commented May 26, 2015

Demo HTML is outdated, using iron-doc-viewer instead of iron-component-page.

@jeffposnick
Copy link
Contributor Author

Thanks, @mbleigh. Serves me right for just looking at the tests 😦

I've switched to <iron-component-page>, and the docs look good. I'm running into Polymer/polymer#1615 which is messing up the demo.

@addyosmani
Copy link
Contributor

@wibblymat is the demo rendering for you now?

@wibblymat
Copy link
Contributor

No, the books dropdown is empty. I reset everything again and did it from a fresh clone.

@notwaldorf
Copy link
Contributor

Oh, ha, I just created the same branch to send a PR for the iron-component-page dependency. I'll nuke it :)

@notwaldorf
Copy link
Contributor

FYI, @garlicnation says that the first line in the docs cannot be the @group Platinum Service Worker Elements bit, since that throws off the parsing, and the docs won't show up

@jeffposnick
Copy link
Contributor Author

I'm running into some issues with the very latest <iron-component-page>, by the way. Looking to debug those in person with some folks from the engineering team soon.

(The issues are that the popup selector to switched between elements in the group isn't working, and it also will only work if platinum-sw-elements.html is renamed platinum-sw.html.)

@jeffposnick
Copy link
Contributor Author

Updating to the very-very-latest versions of all the dependencies seems to lead to a happy demo + docs page + wct.

I've also renamed getParameters() to _getParameters() so that it doesn't show up in the docs as a public method.

PTAL.

@jeffposnick
Copy link
Contributor Author

As per @wibblymat's in-person feedback, I've added in @demo attributes to the elements that are shown off in the demo, since the demo links are generated automatically anymore.

@addyosmani
Copy link
Contributor

This appears to be working now. Was @wibblymat able to get this working from a fresh clone? (seems like it per recent feedback).

@wibblymat
Copy link
Contributor

LGTM 👍 :shipit:

wibblymat added a commit that referenced this pull request May 27, 2015
@wibblymat wibblymat merged commit 5ecbc6c into 0.8-preview May 27, 2015
@wibblymat wibblymat deleted the 0.9.x branch May 27, 2015 00:53
@jeffposnick jeffposnick mentioned this pull request May 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants