Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-1853/ add field for external id to settlements #1280

Merged

Conversation

JMoore96
Copy link
Contributor

changelog

modified API

  • added Instruction with memo
  • updated storage and events

@JMoore96 JMoore96 requested a review from Neopallium July 19, 2022 17:42
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1280 (d5367f4) into develop (609295d) will decrease coverage by 0.11%.
The diff coverage is 12.14%.

@@             Coverage Diff             @@
##           develop    #1280      +/-   ##
===========================================
- Coverage    44.03%   43.92%   -0.12%     
===========================================
  Files          141      141              
  Lines        29686    29788     +102     
===========================================
+ Hits         13073    13083      +10     
- Misses       16613    16705      +92     
Impacted Files Coverage Δ
pallets/weights/src/pallet_settlement.rs 5.38% <0.00%> (-0.66%) ⬇️
pallets/settlement/src/lib.rs 46.80% <12.64%> (-2.41%) ⬇️
pallets/sto/src/lib.rs 24.73% <100.00%> (+0.16%) ⬆️
primitives/src/asset_identifier.rs 97.92% <0.00%> (-0.42%) ⬇️

Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the memo is changed to a fixed-length array, this PR should be finished.

pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
@adamdossa
Copy link
Collaborator

  • We should add a with_memo version of add_and_affirm_instruction
  • We can mark the old add_instruction and add_and_affirm_instruction as deprecated

@JMoore96 JMoore96 changed the title [WIP] MESH-1853/ add field for external id to settlements MESH-1853/ add field for external id to settlements Jul 29, 2022
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
@adamdossa adamdossa merged commit d45fd1a into develop Aug 4, 2022
@adamdossa adamdossa deleted the MESH-1853/-add-field-for-external-id-to-settlements branch August 4, 2022 13:40
@Neopallium Neopallium added storage-modification-changes PR includes changes that modify storage and requires additional logic to upgrade release-notes Tag to use if PR needs to be reflected in release notes and removed storage-modification-changes PR includes changes that modify storage and requires additional logic to upgrade labels Sep 28, 2022
This was referenced Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Tag to use if PR needs to be reflected in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants