Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-1872/ Allow redemptions from non-default portfolios #1292

Merged

Conversation

JMoore96
Copy link
Contributor

@JMoore96 JMoore96 commented Sep 5, 2022

changelog

modified logic

  • added redeem_from_portfolio function
  • added benchmark for redeem_from_portfolio

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1292 (9d4ae8f) into develop (69abd25) will decrease coverage by 0.02%.
The diff coverage is 32.55%.

❗ Current head 9d4ae8f differs from pull request most recent head 387a534. Consider uploading reports for the commit 387a534 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1292      +/-   ##
===========================================
- Coverage    43.85%   43.83%   -0.03%     
===========================================
  Files          141      141              
  Lines        29859    29896      +37     
===========================================
+ Hits         13096    13106      +10     
- Misses       16763    16790      +27     
Impacted Files Coverage Δ
pallets/common/src/traits/asset.rs 0.00% <ø> (ø)
pallets/weights/src/pallet_asset.rs 3.64% <0.00%> (-0.14%) ⬇️
pallets/asset/src/lib.rs 60.32% <37.83%> (-0.50%) ⬇️
primitives/src/identity_claim.rs 63.51% <0.00%> (-1.36%) ⬇️
pallets/identity/src/keys.rs 79.32% <0.00%> (-0.16%) ⬇️
pallets/balances/src/lib.rs 57.10% <0.00%> (-0.14%) ⬇️
primitives/src/asset_identifier.rs 98.34% <0.00%> (+0.41%) ⬆️
pallets/identity/src/claims.rs 90.77% <0.00%> (+0.57%) ⬆️

pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
@JMoore96 JMoore96 requested a review from Neopallium September 9, 2022 17:46
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset/src/lib.rs Show resolved Hide resolved
@JMoore96 JMoore96 requested a review from Neopallium September 12, 2022 17:05
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor change.

pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
@Neopallium Neopallium enabled auto-merge (squash) September 16, 2022 17:56
@Neopallium Neopallium merged commit 19373e1 into develop Sep 16, 2022
@Neopallium Neopallium deleted the MESH-1872/Allow-redemptions-from-non-default-portfolios branch September 16, 2022 18:15
@Neopallium Neopallium added the release-notes Tag to use if PR needs to be reflected in release notes label Sep 28, 2022
This was referenced Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Tag to use if PR needs to be reflected in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants