Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-1870/ During ticker registration reject ASCII control characters (non printable) #1296

Merged
merged 10 commits into from
Oct 5, 2022
Merged

MESH-1870/ During ticker registration reject ASCII control characters (non printable) #1296

merged 10 commits into from
Oct 5, 2022

Conversation

JMoore96
Copy link
Contributor

changelog

modified logic

  • created a check in ticker registration to make sure it is alphanumeric

@JMoore96 JMoore96 requested a review from Neopallium September 15, 2022 13:30
Neopallium
Neopallium reviewed Sep 15, 2022
View reviewed changes
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 19, 2022 •
edited
Loading

Codecov Report

Merging #1296 (d3055ed) into develop (76393bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1296   +/-   ##
========================================
  Coverage    43.90%   43.90%           
========================================
  Files          141      141           
  Lines        29902    29902           
========================================
+ Hits         13128    13129    +1     
+ Misses       16774    16773    -1
Impacted Files Coverage Δ
pallets/asset/src/lib.rs 60.32% <100.00%> (ø)
primitives/src/asset_identifier.rs 98.34% <0.00%> (+0.41%) ⬆️

Neopallium
Neopallium requested changes Sep 19, 2022
View reviewed changes
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
@Neopallium
Copy link
Contributor

Looks like some of the reserved classic tickers don't meet the new rules.

@Neopallium
Copy link
Contributor

Neopallium commented Sep 20, 2022 •
edited
Loading

  • Clear out classic tickers from the src/data/reserved_classic_tickers.json. Just keep about 2 tickers from that file.

@JMoore96 JMoore96 changed the title [WIP] MESH-1870/ During ticker registration reject ASCII control characters (non printable) MESH-1870/ During ticker registration reject ASCII control characters (non printable) Sep 22, 2022
@adamdossa adamdossa enabled auto-merge (squash) October 5, 2022 15:59
@adamdossa adamdossa merged commit 826ca1c into develop Oct 5, 2022
@adamdossa adamdossa deleted the MESH-1870/During-ticker-registration-reject-ASCII-control-characters-(non-printable) branch October 5, 2022 16:15
@adamdossa adamdossa mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdossa adamdossa adamdossa approved these changes

@Neopallium Neopallium Neopallium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JMoore96 @Neopallium @adamdossa