Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-1876/ When removing a permissioned operator, each of its associated nodes (stash keys) should be chilled #1317

Conversation

JMoore96
Copy link
Contributor

changelog

modified API

  • Added new event for chill_from_governance function

modified logic

  • Added new function chill_from_governance

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1317 (242467e) into develop (f10f523) will decrease coverage by 0.02%.
The diff coverage is 32.00%.

@@             Coverage Diff             @@
##           develop    #1317      +/-   ##
===========================================
- Coverage    43.90%   43.88%   -0.03%     
===========================================
  Files          141      141              
  Lines        29994    30043      +49     
===========================================
+ Hits         13170    13185      +15     
- Misses       16824    16858      +34     
Impacted Files Coverage Δ
pallets/staking/src/offchain_election.rs 63.03% <0.00%> (-0.49%) ⬇️
pallets/staking/src/weights.rs 27.52% <0.00%> (ø)
pallets/weights/src/pallet_staking.rs 3.03% <0.00%> (-0.13%) ⬇️
pallets/staking/src/lib.rs 47.54% <43.24%> (+0.05%) ⬆️
pallets/identity/src/lib.rs 15.96% <0.00%> (-0.59%) ⬇️

pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
@Neopallium
Copy link
Contributor

  • Add unit tests for the new extrinsic.

@JMoore96 JMoore96 changed the title [WIP] MESH-1876/ When removing a permissioned operator, each of its associated nodes (stash keys) should be chilled MESH-1876/ When removing a permissioned operator, each of its associated nodes (stash keys) should be chilled Nov 4, 2022
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of cleanup and this PR is ready.

pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/runtime/tests/src/staking/mod.rs Outdated Show resolved Hide resolved
Neopallium and others added 2 commits November 8, 2022 19:52
@JMoore96 JMoore96 requested a review from Neopallium November 8, 2022 15:49
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the description should be improved to describe this new extrinsic.

pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
@adamdossa adamdossa merged commit 4fb6dba into develop Nov 22, 2022
@adamdossa adamdossa deleted the MESH-1876/When-removing-a-permissioned-operator-each-of-its-associated-nodes-(stash-keys)-should-be-chilled branch November 22, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants