Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-1877/ Staking - off-chain election results fails if validator is no longer compliant #1376

Conversation

JMoore96
Copy link
Contributor

changelog

modified logic

  • Added compliance check for validators list and test case to check error

@JMoore96 JMoore96 requested a review from Neopallium January 13, 2023 15:00
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #1376 (437afe8) into develop (86fb46c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1376      +/-   ##
===========================================
+ Coverage    43.26%   43.35%   +0.08%     
===========================================
  Files          140      140              
  Lines        30136    30145       +9     
===========================================
+ Hits         13038    13069      +31     
+ Misses       17098    17076      -22     
Impacted Files Coverage Δ
pallets/staking/src/lib.rs 47.51% <100.00%> (+0.17%) ⬆️
pallets/settlement/src/lib.rs 47.05% <0.00%> (+1.62%) ⬆️

@JMoore96 JMoore96 changed the title [WIP] MESH-1877/ Staking - off-chain election results fails if validator is no longer compliant MESH-1877/ Staking - off-chain election results fails if validator is no longer compliant Jan 19, 2023
…sults-fails-if-validator-is-no-longer-compliant
@adamdossa adamdossa merged commit d72599a into develop Jan 19, 2023
@adamdossa adamdossa deleted the MESH-1877/Staking---off-chain-election-results-fails-if-validator-is-no-longer-compliant branch January 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants