Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh 1929/fix transaction state rollback #1383

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

HenriqueNogara
Copy link
Contributor

Adds an event for failing to execute an Instruction. To avoid rolling back the state (once the code is updated to the new substrate version) the result of execute_instruction_retryable is now matched

changelog

modified API

  • Adds an event: FailedToExecuteInstruction;
  • execute_scheduled_instruction will no longer return an error;

modified logic

  • To avoid a state rollback (i.e allow setting instruction status to the failed state) the return of execute_instruction_retryable is now matched, and returns an event in case of failure.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1383 (6fd9184) into develop (b011077) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
- Coverage    43.34%   43.26%   -0.09%     
===========================================
  Files          140      140              
  Lines        30132    30136       +4     
===========================================
- Hits         13060    13037      -23     
- Misses       17072    17099      +27     
Impacted Files Coverage Δ
pallets/settlement/src/lib.rs 45.43% <0.00%> (-1.76%) ⬇️
primitives/src/asset_identifier.rs 97.92% <0.00%> (-0.42%) ⬇️

@Neopallium Neopallium merged commit 86fb46c into develop Jan 19, 2023
@Neopallium Neopallium deleted the MESH-1929/fix-transaction-state-rollback branch January 19, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants