Mesh 2133/return extrinsic errors #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriqueNogara
commented
Dec 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nft-sc-draft #1581 +/- ##
================================================
- Coverage 58.67% 58.67% -0.01%
================================================
Files 142 142
Lines 32236 32236
================================================
- Hits 18915 18914 -1
- Misses 13321 13322 +1 |
HenriqueNogara
commented
Dec 21, 2023
Neopallium
approved these changes
Jan 15, 2024
HenriqueNogara
force-pushed
the
MESH-2133/return-extrinsic-errors
branch
from
44cec9d to
ae49996
Compare
Neopallium
reviewed
Jan 15, 2024
Neopallium
approved these changes
Jan 16, 2024
adamdossa
approved these changes
Jan 16, 2024
Neopallium
added a commit
that referenced
this pull request
Jan 17, 2024
* Add nft_royalty contract dir * Add the first draft for the following functions: royalty_percentage, asset_metadata_value, get_royalty_amount, new * Add setup_legs first draft; Add NFTOffer type * Move tests; Move types * Add royalty_portfolios to storage; Improve create_transfer draft; Add first draft of NFTArtistRules * Add metadata_keys mapping * Fix clippy warnings * Add create_custody_portfolio draft * Add PolymeshInk * Fix compilation * Fix toml; Remove unused dependency * Add PolymeshInk query calls * Add value to const; Fix error msg * Add PolymeshInk::get_our_did() call for updating the contract's did * Improve docs * Add readme file * Add contract initialization * Remove polymesh-api dependency; Improve readme; Add artist_identity to NFTArtistRules * Improve readme * Add debug_println to create_transfer; Update .toml and .lock * Mesh 2133/return extrinsic errors (#1581) * Write extrinsic error to output buffer * Remove support for FuncId::OldCallRuntime; Add CallRuntimeWithError * Split contract tests; Change test to use call_runtime instead of old_call_runtime * Add InkDelegateCallError back * Update polymesh-api dependency * Add use_call_runtime_with_error * Add use_call_runtime_with_error as a feature flag * Add initialization flag; Remove api from storage; Deduct royalty from tranfer price --------- Co-authored-by: Adam Dossa <adam.dossa@gmail.com> Co-authored-by: Robert Gabriel Jakabosky <rjakabosky+neopallium@neoawareness.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
call_runtime_with_errorwrites aResult<(), String>to the output buffer, which can be used for more descriptive error msg.changelog
new features
CallRuntimeWithErrorchain_extension;modified external API
OldCallRuntime;new external API
CallRuntimeWithErrorchain_extension;