Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-2145/allow-the-owner-to-reject-proposal #1632

Merged
merged 7 commits into from
Apr 11, 2024
Merged

MESH-2145/allow-the-owner-to-reject-proposal #1632

merged 7 commits into from
Apr 11, 2024

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Mar 28, 2024 •
edited
Loading

Change MS reject proposal logic. If no one else has voted, allows the owner of the proposal to reject it immediately.

changelog

new features

  • If no one else has voted, allows the owner of the proposal to reject it immediately.

new events

  • Adds the ProposalFailedToExecute event to the multsig pallet;

@HenriqueNogara HenriqueNogara changed the title Change proposal rejection logic MESH-2145/single-vote-should-reject-proposal Mar 28, 2024
Neopallium
Neopallium requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single reject vote shouldn't put the proposal into the Rejected state.

@HenriqueNogara HenriqueNogara changed the title MESH-2145/single-vote-should-reject-proposal WIP: MESH-2145/single-vote-should-reject-proposal Apr 2, 2024
@HenriqueNogara HenriqueNogara force-pushed the MESH-2145/single-vote-should-reject-proposal branch from b07096a to dcf24cc Compare April 3, 2024 17:24
@HenriqueNogara HenriqueNogara changed the title WIP: MESH-2145/single-vote-should-reject-proposal WIP: MESH-2145/allow-the-owner-to-reject-proposal Apr 3, 2024
@HenriqueNogara HenriqueNogara changed the title WIP: MESH-2145/allow-the-owner-to-reject-proposal MESH-2145/allow-the-owner-to-reject-proposal Apr 3, 2024
@adamdossa adamdossa merged commit e3f6819 into develop Apr 11, 2024
13 checks passed
@adamdossa adamdossa deleted the MESH-2145/single-vote-should-reject-proposal branch April 11, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdossa adamdossa adamdossa approved these changes

@Neopallium Neopallium Neopallium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenriqueNogara @Neopallium @adamdossa