Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New confidential pallet #405

Merged
merged 40 commits into from
Jul 21, 2020
Merged

New confidential pallet #405

merged 40 commits into from
Jul 21, 2020

Conversation

fmiguelgarcia
Copy link
Contributor

@fmiguelgarcia fmiguelgarcia commented May 19, 2020 •
edited
Loading

  • Integration of cryptography library in Polymesh: native & wasm.
  • Initial Confidential pallet for testing the integration. It uses prove_within_range and verify_range_proof.
  • Crytp as submodule. It is tracking the CRYP-119/split_crypto branch until that Jira will be merged.
  • RNG as a hosted function for WASM builds.
  • wasm-builder customization to add no_std feature in wasm builds. It is needed due to backend of curve25519 crate.
  • CI build using submodule.

@fmiguelgarcia fmiguelgarcia self-assigned this May 19, 2020
@fmiguelgarcia fmiguelgarcia changed the title New confidential pallet [WIP] New confidential pallet May 19, 2020
@fmiguelgarcia fmiguelgarcia requested review from a user, ajivanyan and ParnianAlimi May 28, 2020 10:47
@fmiguelgarcia fmiguelgarcia marked this pull request as ready for review June 19, 2020 09:19
@fmiguelgarcia fmiguelgarcia changed the title [WIP] New confidential pallet New confidential pallet Jul 1, 2020
@fmiguelgarcia fmiguelgarcia requested a review from adamdossa July 1, 2020 14:57
maxsam4
maxsam4 suggested changes Jul 9, 2020
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
pallets/confidential/src/lib.rs Show resolved Hide resolved
pallets/confidential/src/lib.rs Show resolved Hide resolved
polymesh_schema.json Outdated Show resolved Hide resolved
@adamdossa adamdossa added the merge-after-ci PR can be merged after CI has completed label Jul 13, 2020
vkomenda
vkomenda reviewed Jul 13, 2020
View reviewed changes
pallets/confidential/Cargo.toml Outdated Show resolved Hide resolved
pallets/runtime/common/tests/all/mod.rs Outdated Show resolved Hide resolved
pallets/runtime/develop/src/runtime.rs Outdated Show resolved Hide resolved
pallets/runtime/develop/src/runtime.rs Outdated Show resolved Hide resolved
@fmiguelgarcia fmiguelgarcia changed the title New confidential pallet [WIP] New confidential pallet Jul 13, 2020
vkomenda
vkomenda reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@vkomenda vkomenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a couple remarks. I'm not sure what the transaction payment unit tests are not using the common test runtime struct.

pallets/runtime/common/src/bridge.rs Show resolved Hide resolved
pallets/runtime/tests/all/transaction_payment_test.rs Outdated Show resolved Hide resolved
@fmiguelgarcia fmiguelgarcia changed the title [WIP] New confidential pallet New confidential pallet Jul 21, 2020
@poly-auto-merge poly-auto-merge bot merged commit 69a266f into develop Jul 21, 2020
@Centril Centril deleted the CRYP-92/integration_test branch May 11, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkomenda vkomenda vkomenda left review comments

@satyamakgec satyamakgec satyamakgec approved these changes

@maxsam4 maxsam4 maxsam4 approved these changes

@adamdossa adamdossa adamdossa approved these changes

@ajivanyan ajivanyan Awaiting requested review from ajivanyan

@ParnianAlimi ParnianAlimi Awaiting requested review from ParnianAlimi

Assignees

@fmiguelgarcia fmiguelgarcia

Labels
merge-after-ci PR can be merged after CI has completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fmiguelgarcia @adamdossa @vkomenda @maxsam4 @satyamakgec @ParnianAlimi @ajivanyan