Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rust-toolchain to 2020-07-11 #479

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Pin rust-toolchain to 2020-07-11 #479

merged 3 commits into from
Jul 22, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 22, 2020

@Centril Centril requested review from maxsam4 and satyamakgec July 22, 2020 08:30
@maxsam4
Copy link
Contributor

maxsam4 commented Jul 22, 2020

@Centril Changes look good to me. Some additional suggestions about the script: Since we are now pinning the toolchain via the toolchain file, we can remove the rustup update commands from the init script. Also, when installing wasm-gc, we don't need to specify +nightly.

@Centril
Copy link
Contributor Author

Centril commented Jul 22, 2020

@maxsam4 Addressed. :)

@maxsam4 maxsam4 added the merge-after-ci PR can be merged after CI has completed label Jul 22, 2020
@poly-auto-merge poly-auto-merge bot merged commit 599f6a2 into develop Jul 22, 2020
@Centril Centril deleted the pin-2020-07-11 branch July 22, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-after-ci PR can be merged after CI has completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants