fix: 🐛 fix instruction from middleware with SQ v19+ #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-OBrien
reviewed
Dec 10, 2024
VictorVicente
previously approved these changes
Dec 10, 2024
polymath-eric
force-pushed
the
fix-sq-instruction
branch
from
c733122 to
0169504
Compare
|
/fast-forward |
|
Triggered from #1410 (comment) by @polymath-eric. Trying to fast forward Target branch ( commit 8260aacd31d78e376aea5dee6adbbc46bb039762 (HEAD -> alpha, tag: v27.0.3-alpha.1, origin/alpha)
Author: Eric Richardson <eric@polymesh.network>
Date: Mon Dec 9 09:32:26 2024 -0500
docs: ✏️ update deprecated note to reference correct field
Update deprecated notices to include "Created" where needed, e.g.
`BlockIdDesc` -> `CreatedBlockIdDesc`Pull request ( commit 0169504cb2a7b80a5bf9b0ea434187e72dbf0fbb (pull_request/fix-sq-instruction)
Author: Eric Richardson <eric@polymesh.network>
Date: Mon Dec 9 19:42:48 2024 -0500
fix: 🐛 fix instruction from middleware with SQ v19+Fast forwarding $ git push origin 0169504cb2a7b80a5bf9b0ea434187e72dbf0fbb:alpha
remote: error: GH006: Protected branch update failed for refs/heads/alpha.
remote:
remote: - All comments must be resolved.
To https://github.com/PolymeshAssociation/polymesh-sdk.git
! [remote rejected] 0169504cb2a7b80a5bf9b0ea434187e72dbf0fbb -> alpha (protected branch hook declined)
error: failed to push some refs to 'https://github.com/PolymeshAssociation/polymesh-sdk.git' |
polymath-eric
force-pushed
the
fix-sq-instruction
branch
from
0169504 to
5917116
Compare
|
F-OBrien
approved these changes
Dec 10, 2024
VictorVicente
approved these changes
Dec 10, 2024
|
/fast-forward |
|
🎉 This PR is included in version 27.0.3-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
JIRA Link
Checklist