fixed the woff2 parsing? #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
commented
Apr 23, 2021
Comment on lines
-18
to
+19
| constructor(name, dict, dataview) { | ||
| const { p, tableStart } = super(name, dict, dataview); | ||
| constructor(dict, dataview, name) { | ||
| const { p, tableStart } = super(dict, dataview, name); |
There was a problem hiding this comment.
how the hell did this work before? O_o
|
Browser on the left, Node on the right: |
Pomax
commented
Apr 23, 2021
Comment on lines
+7
to
+11
| if (!brotliDecode) { | ||
| import("zlib").then((zlib) => { | ||
| nativeBrotliDecode = (buffer) => zlib.brotliDecompressSync(buffer); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is a dynamic import, but for a native module, so while in theory this might kick in "after everything else": in reality it gets executed immediately.
Pomax
commented
Apr 23, 2021
src/opentype/woff2.js
Outdated
Comment on lines
126
to
128
| const start = entry.offset; | ||
| const end = start + (entry.transformLength ? entry.transformLength : entry.origLength); | ||
| const data = decoded.slice(start, end); |
There was a problem hiding this comment.
Note that this does not have any code in place to deal with transformed glyf, loca, or hmtx tables yet. I've filed #118 to address that in the future.
RoelN
approved these changes
May 20, 2021
Comment on lines
-18
to
+19
| constructor(name, dict, dataview) { | ||
| const { p, tableStart } = super(name, dict, dataview); | ||
| constructor(dict, dataview, name) { | ||
| const { p, tableStart } = super(dict, dataview, name); |
RoelN
reviewed
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115 by updating the woff2 table data parsing code, as well as using Node's native brotli decoding (via the
zlibmodule) rather than trying toimportthelib/unbrotli.jsfile, which isn't a module.\@RoelN if you create a dir called
fonts/brokenand put the fonts from #114 in there, the newnpm run test:manualshould allow you to verify things work in the browser, with the followingtest.jsfile that you can run withnode test.jsto verify things work on the node side, too: