Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to EF Core 9.0.0 #1948

Merged
merged 19 commits into from
Dec 7, 2024
Merged

Conversation

lauxjpn
Copy link
Collaborator

@lauxjpn lauxjpn commented Nov 28, 2024

Everything compiles and all of our custom, integration and existing functional tests are green for MySQL 8.

We currently have the following test statistics (in regards to MySQL 8):

Test suite Number of tests Number of failing tests
Functional 30,882 0
Integration 37 0
Custom 76 0
  • All projects compile
  • All existing test classes work
  • Update CI dependencies for Windows
  • Explicitly support all major database server implementations and their currently active release trains through our test suite:
    • MySQL 8.4
    • MySQL 8.0
    • MariaDB 11.6
    • MariaDB 11.5
    • MariaDB 11.4
    • MariaDB 11.3
    • MariaDB 10.11
    • MariaDB 10.6
    • MariaDB 10.5

We will implement new EF Core 9 features in an upcoming release.

There are a couple of TODOs (marked as TODO: 9.0 in the codebase) that should be checked/addressed before a GA release.

Addresses #1841

@lauxjpn lauxjpn added this to the 9.0.0-alpha.1 milestone Nov 28, 2024
@lauxjpn lauxjpn self-assigned this Nov 28, 2024
@lauxjpn lauxjpn requested a review from a team as a code owner November 28, 2024 22:01
@lauxjpn lauxjpn force-pushed the upgrade/9.0.0 branch 5 times, most recently from bbeb2b7 to f11bfc0 Compare November 30, 2024 06:34
@ChrisJollyAU
Copy link

@lauxjpn Just watch out with the selectExpression.Update - the order of offset and limit has been switched around in 9.0. If you haven't already picked that up

@lauxjpn lauxjpn force-pushed the upgrade/9.0.0 branch 2 times, most recently from 89a942b to 63e5009 Compare November 30, 2024 14:38
@lauxjpn
Copy link
Collaborator Author

lauxjpn commented Nov 30, 2024

@ChrisJollyAU Thanks, I stumbled across this while upgrading, but thought I had just made a mistake while editing the code. I fixed it now in the entire codebase.

@ChrisJollyAU
Copy link

@ChrisJollyAU Thanks, I stumbled across this while upgrading, but thought I had just made a mistake while editing the code. I fixed it now in the entire codebase.

Yeah, was rather subtle

@lauxjpn lauxjpn force-pushed the upgrade/9.0.0 branch 6 times, most recently from 35199d0 to 2f7eca5 Compare December 6, 2024 08:17
…e order of AUTO_INCREMENT columns in a compound primary key, if the column is not the first one in the key.

To make this production-ready (especially migration upgrade compatible), further steps need to be taken.
@lauxjpn lauxjpn force-pushed the upgrade/9.0.0 branch 2 times, most recently from f349757 to 52da718 Compare December 7, 2024 18:16
@lauxjpn lauxjpn merged commit fde6828 into PomeloFoundation:main Dec 7, 2024
19 checks passed
@lauxjpn lauxjpn deleted the upgrade/9.0.0 branch December 7, 2024 19:28
@lauxjpn lauxjpn modified the milestones: 9.0.0-alpha.1, 9.0.0-preview.2.efcore.9.0.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants