-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve database reverse engineering #896
Conversation
Add comments for tables and columns. Improve handling of default values.
Introduce a workaround for the missing EF Core handling of `ValueGenerated.OnUpdate`. Fixes PomeloFoundation#877
There was an issue previously where The workaround was to use a regular expression to strip away the display width which your PR removes. The orginal upstream type mapping code in CreateMappingFromStoreType now appears to be in ParseStoreTypeName. |
Can probably remove this code as it only applies to Release Candidate not General Availability versions. https://bugs.mysql.com/bug.php?id=89793 >The NON_UNIQUE column in the INFORMATION_SCHEMA.STATISTICS table had type BIGINT prior to MySQL 8.0, but became VARCHAR in MySQL 8.0 with the introduction of the data dictionary. The NON_UNIQUE column now has an integer type again (INT because the column need not be as large as BIGINT).
Thanks for pointing out the regression and doing the research on the method to override! |
…r display width to CLR types.
Add support to reverse engineer views.
Add comments for tables and columns.
Improve handling of default values.
Handle the
CURRENT_TIMESTAMP
default value fortimestamp
columns correctly.Correctly implement
CURRENT_TIMESTAMP
withON UPDATE
clauses.Introduce a workaround for the missing EF Core handling of
ValueGenerated.OnUpdate
.Fixes #877
Fixes #867
Fixes #703
Fixes parts of #792 (others are blocked by an EF Core issue)