GqlEdges sorting #1906
Merged
GqlEdges sorting #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide a
sortedfield to GqlEdges so that the client may query for a list of edges sorted by some criteria. Currently supports sorting by src ID, dst ID, latest time, earliest time, property value (viaproperties, i.e. the unified properties), passing in multiple fields to sort by in order of priority, and reversing the sort.Why are the changes needed?
Timestamp sorting was requested by client
Does this PR introduce any user-facing change? If yes is this documented?
Yes, GraphQL API is currently not documented
How was this patch tested?
Some basic tests run in the GraphQL Playground to test the query, and unit tests were added to
python/tests/graphql/test_edge_sorting.py.Are there any further changes required?
Some improvements to the API to allow for sorting by constant properties and temporal properties specifically could be possible in the future, if need be.