Change explode and explode layers to return GQL edges #1910
+5
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachchan
changed the title
rachchan
force-pushed
the
feature/explodegqledges
branch
from
b053379 to
79afe19
Compare
miratepuffin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the graphql edges API, I've changed explode and explode_layers to return GqlEdges rather than an array of Edge
Why are the changes needed?
I need pagination of exploded edges
Does this PR introduce any user-facing change? If yes is this documented?
was it documented in the first place....
How was this patch tested?
Tested in playground
Are there any further changes required?
no