add annotation + refactor

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Poojita-Raj · Aug 4, 2023 · 342b6ed · 342b6ed
1 parent 7f7df45
commit 342b6ed
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/routing/ShardMovementStrategy.java b/server/src/main/java/org/opensearch/cluster/routing/ShardMovementStrategy.java
@@ -17,6 +17,8 @@
  *
  * ShardMovementStrategy values or rather their string representation to be used with
  * {@link BalancedShardsAllocator#SHARD_MOVEMENT_STRATEGY_SETTING} via cluster settings.
+ *
+ * @opensearch.internal
  */
 public enum ShardMovementStrategy {
     /**

diff --git a/server/src/test/java/org/opensearch/cluster/routing/RoutingNodesTests.java b/server/src/test/java/org/opensearch/cluster/routing/RoutingNodesTests.java
@@ -156,11 +156,11 @@ public void testInterleavedShardIteratorPrimaryFirst() {
             if (iteratingPrimary) {
                 iteratingPrimary = shard.primary();
             } else {
-                assert shard.primary() == false;
+                assertFalse(shard.primary());
             }
             shardCount++;
         }
-        assert shardCount == this.totalNumberOfShards;
+        assertEquals(shardCount, this.totalNumberOfShards);
     }
 
     public void testInterleavedShardIteratorNoPreference() {
@@ -178,7 +178,7 @@ public void testInterleavedShardIteratorNoPreference() {
             final ShardRouting shard = iterator.next();
             shardCount++;
         }
-        assert shardCount == this.totalNumberOfShards;
+        assertEquals(shardCount, this.totalNumberOfShards);
     }
 
     public void testInterleavedShardIteratorReplicaFirst() {
@@ -199,11 +199,11 @@ public void testInterleavedShardIteratorReplicaFirst() {
             if (iteratingReplica) {
                 iteratingReplica = shard.primary() == false;
             } else {
-                assert shard.primary() == true;
+                assertTrue(shard.primary());
             }
             shardCount++;
         }
-        assert shardCount == this.totalNumberOfShards;
+        assertEquals(shardCount, this.totalNumberOfShards);
     }
 
     public void testSwapPrimaryWithReplica() {