style: Improve consistency of some icons (#137)

Signed-off-by: starry-shivam <starry@krsh.dev>
Pool-Of-Tears · May 20, 2024 · a6725cd · a6725cd
1 parent dd10743
commit a6725cd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 28 deletions.
diff --git a/.idea/deploymentTargetSelector.xml b/.idea/deploymentTargetSelector.xml
diff --git a/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt b/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt
@@ -206,29 +206,28 @@ fun GoalItemClassic(
 
                 Spacer(
                     modifier = Modifier
-                        .height(1.dp)
                         .weight(1f)
                 )
 
-                IconButton(onClick = { onInfoClicked() }) {
+                IconButton(onClick = onInfoClicked) {
                     Icon(
-                        modifier = Modifier.size(24.dp),
+                        modifier = Modifier.size(21.dp),
                         imageVector = ImageVector.vectorResource(id = R.drawable.ic_goal_info),
                         contentDescription = stringResource(id = R.string.info_button_description),
                         tint = MaterialTheme.colorScheme.onSurface
                     )
                 }
-                IconButton(onClick = { onEditClicked() }) {
+                IconButton(onClick = onEditClicked) {
                     Icon(
-                        modifier = Modifier.size(24.dp),
+                        modifier = Modifier.size(21.dp),
                         imageVector = ImageVector.vectorResource(id = R.drawable.ic_goal_edit),
                         contentDescription = stringResource(id = R.string.edit_button_description),
                         tint = MaterialTheme.colorScheme.onSurface
                     )
                 }
-                IconButton(onClick = { onDeleteClicked() }) {
+                IconButton(onClick = onDeleteClicked) {
                     Icon(
-                        modifier = Modifier.size(24.dp),
+                        modifier = Modifier.size(21.dp),
                         imageVector = ImageVector.vectorResource(id = R.drawable.ic_goal_delete),
                         contentDescription = stringResource(id = R.string.delete_button_description),
                         tint = MaterialTheme.colorScheme.onSurface

diff --git a/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/HomeAppBars.kt b/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/HomeAppBars.kt
@@ -30,13 +30,13 @@ import androidx.compose.animation.core.tween
 import androidx.compose.foundation.layout.WindowInsets
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.statusBars
 import androidx.compose.foundation.layout.windowInsetsPadding
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.foundation.text.KeyboardActions
 import androidx.compose.foundation.text.KeyboardOptions
 import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.automirrored.filled.Sort
 import androidx.compose.material.icons.filled.Close
 import androidx.compose.material.icons.filled.Menu
 import androidx.compose.material.icons.filled.Search
@@ -57,10 +57,8 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.focus.FocusRequester
 import androidx.compose.ui.focus.focusRequester
 import androidx.compose.ui.graphics.Color
-import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.platform.LocalView
 import androidx.compose.ui.res.stringResource
-import androidx.compose.ui.res.vectorResource
 import androidx.compose.ui.text.input.ImeAction
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
@@ -147,9 +145,8 @@ private fun DefaultAppBar(
                 onFilterClicked()
             }) {
                 Icon(
-                    imageVector = ImageVector.vectorResource(id = R.drawable.ic_menu_filter),
+                    imageVector = Icons.AutoMirrored.Filled.Sort,
                     contentDescription = stringResource(id = R.string.filter_button_desc),
-                    modifier = Modifier.size(22.dp)
                 )
             }
             IconButton(onClick = {

diff --git a/app/src/main/res/drawable/ic_menu_filter.xml b/app/src/main/res/drawable/ic_menu_filter.xml