fix: remove unnecessary code

PoolC · Jul 15, 2024 · 953b337 · 953b337
1 parent 707cdce
commit 953b337
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/main/java/org/poolc/api/notification/controller/NotificationController.java b/src/main/java/org/poolc/api/notification/controller/NotificationController.java
@@ -24,6 +24,9 @@ public class NotificationController {
     @GetMapping("/unread")
     public ResponseEntity<List<NotificationResponse>> getUnreadNotifications(@AuthenticationPrincipal Member member) {
         List<Notification> notifications = notificationService.getUnreadNotificationsForMember(member.getLoginID());
+        if (notifications.isEmpty()) {
+            return ResponseEntity.status(HttpStatus.NO_CONTENT).build();
+        }
         List<NotificationResponse> responses = notifications.stream()
                 .map(NotificationResponse::of)
                 .collect(Collectors.toList());

diff --git a/src/main/java/org/poolc/api/notification/service/NotificationService.java b/src/main/java/org/poolc/api/notification/service/NotificationService.java
@@ -46,14 +46,6 @@ public List<Notification> getAllNotificationsForMember(String receiverId) {
                 .sorted(Comparator.comparing(Notification::getCreatedAt).reversed())
                 .collect(Collectors.toList());
 
-        if (!notifications.isEmpty()) {
-            notifications.forEach(notification -> {
-                if (notification != null) {
-                    notification.memberReads();
-                }
-            });
-        }
-
         Member recipient = getMemberByLoginID(receiverId);
         if (recipient == null) {
             throw new IllegalArgumentException("Recipient not found for the given receiverId");