alsa: do not link with lasound in the PA_ALSA_DYNAMIC case #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I'm not competent to sign off on a CMake change. @Be-ing ? If anyone with CMake chops could comment that would be a great help. |
@RossBencina the change looks correct and can be safely merged. When |
dmitrykos
approved these changes
Oct 31, 2023
RossBencina
approved these changes
Dec 22, 2023
philburk
approved these changes
Dec 22, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it kinda defeats the point of the option (making binaries that will still run on systems without libasound.so.2)