Pulseaudio: Termination stream before operation release can lead locking #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuusio
added
bug
kleinerm
reviewed
Oct 20, 2024
illuusio
force-pushed
the
pulseaudio-termination-too-soon
branch
2 times, most recently
from
3fbac14
to
6d03bb5
Compare
|
@kleinerm could you approve this so I can merge it to repo.. |
|
@illuusio Looks good to me, approved. |
kleinerm
approved these changes
Nov 11, 2024
RossBencina
reviewed
Nov 15, 2024
philburk
reviewed
Nov 21, 2024
RossBencina
reviewed
Nov 21, 2024
Cases when Pulseaudio server releases stream before operation releasing can be lead locking in pa_threaded_mainloop_wait forever. Test if operation is running before running pa_threaded_mainloop_wait which should prevent forever waiting releasing lock.
As documentation says: This function may not be called inside the event loop thread. Events that are dispatched from the event loop thread are executed with this lock held. Add small debug print that makes sure that future code won't be calling it from main thread.
illuusio
force-pushed
the
pulseaudio-termination-too-soon
branch
from
6d03bb5
to
80b1168
Compare
RossBencina
approved these changes
Nov 25, 2024
philburk
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases when Pulseaudio server releases stream before operation releasing can be lead locking in pa_threaded_mainloop_wait forever.
Test if operation is running before running pa_threaded_mainloop_wait which should prevent forever waiting releasing lock.