Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional annotations and service type #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

H4CKS4F3
Copy link

@H4CKS4F3 H4CKS4F3 commented Feb 14, 2024

The helm chart today is platform agnostic and establishes an ingress prerequisite. The proposed solution allows consumers to optionally define platform specific needs (annotations and service type). When omitted, the service will deploy exactly as it does today. When present, annotations and/or service type can be defined and controlled by the consumer.

This can allow for AWS and Azure deployments like so:
values.yaml example for AWS:

services:
  webServer:
    type: ClusterIP

values.yaml example for Azure:

services:
  webServer:
    annotations:
      service.beta.kubernetes.io/azure-load-balancer-internal: "true"
    type: LoadBalancer

Since these are optional, this is backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant