Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs with Chinese #159

Merged
merged 12 commits into from
Apr 10, 2024
Merged

docs with Chinese #159

merged 12 commits into from
Apr 10, 2024

Conversation

ye4293
Copy link
Contributor

@ye4293 ye4293 commented Jan 21, 2024 •
edited
Loading

Title:
docs with Chinese

Description: (optional)

  • add README.cn.md
  • add CONTRIBUTING.cn.md
  • add CODE_OF_CONDUCT.cn.md
  • change CODE_OF_CONDUCT.md
  • A directly spliced hyperlink was used because it was not expected to be parsed into bolb/main, but instead was always parsed into tree/. If there is an easy way, you can modify it directly

Motivation: (optional)

  • make the project more widely disseminated

Related Issues: (optional)

  • #issue-number

@vrushankportkey vrushankportkey self-requested a review January 22, 2024 04:40
roh26it
roh26it requested changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@roh26it roh26it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution! Docs in Chinese would really help with wider community!

Only 1 minor change which in my opinion wouldn't be needed in the English docs, otherwise this looks good to me.

.github/CODE_OF_CONDUCT.md
# Contributor Covenant Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
community a harassment-free experience for everyone, regardless of age, bodys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ye4293 Hi, is this a necessary change?

vrushankportkey
vrushankportkey requested changes Mar 6, 2024
View reviewed changes
.github/CODE_OF_CONDUCT.md
# Contributor Covenant Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
community a harassment-free experience for everyone, regardless of age, bodys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we retain "body"

@vrushankportkey
Copy link
Collaborator

addresses #296

@VisargD VisargD merged commit a846776 into Portkey-AI:main Apr 10, 2024
1 check passed
@VisargD VisargD linked an issue Apr 10, 2024 that may be closed by this pull request
Chinese docs #296
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrushankportkey vrushankportkey vrushankportkey requested changes

@roh26it roh26it roh26it requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chinese docs
4 participants
@ye4293 @vrushankportkey @roh26it @VisargD