-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bedrock mistral #268
Bedrock mistral #268
Conversation
Hey @aashsach - Thanks for the PR. We have released some changes today related to code formatting as well as some changes related to provider config structure. You will have to update your branch with those changes. |
Please let me know if you need any help with this. |
09efe19
to
52418b1
Compare
@aashsach - For all the current bedrock models, we support chat as well as complete requests by making transformations accordingly. In case of mistral, we can transform |
reuse error transform functions.
@VisargD mistral models are only text models, do not support chat modality as per confirmed from their playground, chat playground doesn't support mistral |
Correct. They are text models. But gateway internally makes transformations to convert chat completions input to text completions input. This is done to just make gateway more flexible in terms of request signature. You can check the |
done |
Apart from the one open comment related to complete non-stream token count, everything else looks good. I will run final tests and merge the PR once the comment is resolved. |
…MistralCompleteConfig
LGTM |
Title:
Description: (optional)
Motivation: (optional)
Related Issues: (optional)