Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat all uppercase plugin #570

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

shaun-ak
Copy link
Contributor

@shaun-ak shaun-ak commented Sep 2, 2024

[New Plugin] all uppercase plugin

  • Plugin that gives a true verdict if all characters in a sentence/text is uppercase.

Related Issues: (optional)

@shaun-ak shaun-ak changed the title Feat/all uppercase plugin Feat all uppercase plugin Sep 2, 2024
package.json Outdated Show resolved Hide resolved
@shaun-ak
Copy link
Contributor Author

shaun-ak commented Sep 7, 2024

Hey @VisargD , any update on this?

I am waiting for this to get merged, I am looking to work on all other plugins once this is merged (and if any changes are required, I will know it from this PR and will not repeat it for other plugins)

@VisargD
Copy link
Collaborator

VisargD commented Sep 7, 2024

Hey @shaun-ak. Sorry for the delay. I had one last suggestion. Can we add this to the default plugin directory instead of creating a new plugin? This is a deterministic checks so it fits well with other default plugins.

@shaun-ak
Copy link
Contributor Author

shaun-ak commented Sep 7, 2024

Sure, will do that. Thanks.

@shaun-ak
Copy link
Contributor Author

shaun-ak commented Sep 7, 2024

Hey @VisargD , I moved the plugin to default, please re-review.

@shaun-ak
Copy link
Contributor Author

Hey @VisargD , fixed it, please re-review.

@VisargD VisargD merged commit 3bb3a80 into Portkey-AI:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants