Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: combine system messages for anthropic #575

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: combine system messages for anthropic #575

merged 1 commit into from
Sep 10, 2024

Conversation

jpulec
Copy link
Contributor

@jpulec jpulec commented Sep 5, 2024

Title:
Combine all system prompts into one prompt for anthropic.

Motivation:

  • Most other providers support multiple system prompts, so this makes anthropic more consistent with other providers.

Related Issues:

narengogi
narengogi approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@narengogi narengogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice minimal fix!

@VisargD VisargD merged commit bd4d25a into Portkey-AI:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VisargD VisargD VisargD approved these changes

@narengogi narengogi narengogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpulec @narengogi @VisargD