Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstage.ai #608

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Upstage.ai #608

merged 4 commits into from
Sep 27, 2024

Conversation

shivam-pareek
Copy link
Contributor

Title:

  • Added upstage.ai as a provider

Description: (optional)

  • chat completion endpoint
  • embeddings endpoint

Related Issues: (optional)

@@ -42,6 +42,7 @@ import HuggingfaceConfig from './huggingface';
import { cerebrasProviderAPIConfig } from './cerebras';
import { InferenceNetProviderConfigs } from './inference-net';
import SambaNovaConfig from './sambanova';
import { UpstageProviderConfig } from './upstage';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to UpstageConfig to keep with the convention we've been following above (I can see InferenceNet and cerebras are also named this way, but those have to be changed as well)

Copy link
Contributor

@narengogi narengogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commented on variable renaming required

@VisargD VisargD merged commit e23bd40 into Portkey-AI:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants