Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added max_completion_tokens for chat complete #617

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

shivam-pareek
Copy link
Contributor

Title:

  • max_completion_tokens has been integrated

Description: (optional)

  • To keep the providers open ai compliant

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the transformGenerationConfig function present in this same file

@VisargD
Copy link
Collaborator

VisargD commented Sep 17, 2024

@shivam-pareek - Bedrock has multiple chat configs for different sub-providers. Can you please add mapping to all of them? Same for Vertex.

@shivam-pareek
Copy link
Contributor Author

@shivam-pareek - Bedrock has multiple chat configs for different sub-providers. Can you please add mapping to all of them? Same for Vertex.

ya sure

@VisargD VisargD merged commit a65600e into Portkey-AI:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants