added valid number range #679
Conversation
| target: Number, | ||
| lowerLimit: Number, | ||
| upperLimit: Number |
There was a problem hiding this comment.
Number isn't a type. use number instead.
| try { | ||
| return target >= lowerLimit && target <= upperLimit; | ||
| } catch (error) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think this logic is what the expectation is. Ideally plugins are used as part of generation so we must be able to use this rule with generated content. This rule must check weather the generated content (number) is within the range.
use getText function to retrieve the message content and make sure the content is number (or possibly use regex to extract number from the message content) and do validation with the extracted number.
Check existing plugins here: https://github.com/Portkey-AI/gateway/tree/main/plugins/default
|
Hey @nikhil-kumar94 and @b4s36t4 , is there any blocker for this PR? Please let me know if you have any doubts. |
Title:
Related Issues: