Support shorthand format for guardrails in config #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisargD
reviewed
Nov 12, 2024
| @@ -784,6 +810,16 @@ export async function tryTargetsRecursively( | |||
| currentTarget.requestTimeout = inheritedConfig.requestTimeout; | |||
| } | |||
|
|
|||
| if (currentTarget.inputGuardrails) { | |||
There was a problem hiding this comment.
Should we also handle scenario where user might have sent both: before_request_hooks and input_guardrails?
narengogi
reviewed
Nov 14, 2024
| @@ -141,3 +141,4 @@ build | |||
| .idea | |||
| plugins/**/.creds.json | |||
| plugins/**/creds.json | |||
| src/handlers/test.ts | |||
|
We should also support ids as part of this. Will need to add that to the Portkey middleware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.