Fix BinarySearch type issue in ConvertTo-SourceLineNumber #132
Conversation
Fixes #131 This type issue was introduced since Pwsh 7.5.0 is based on .Net 9. This solution is to type cast the variable and align it to be the same type. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/PoshCode/ModuleBuilder/issues/131?shareId=XXXX-XXXX-XXXX-XXXX).
|
@Jaykul can you please review my proposal for the type issue in combination with Pwsh 7.5.0 |
Changed line 61 instead of 76 due to cleaner coding and accomplishing the same
removed comment from previous commit
removed unnecessary whitespace
undo change to parameter type
undo uppercase to lower case change
|
@Jaykul can you please review the PR? I updated the code and reverted any unnecessary changes according the remarks of @dan-hughes and @johlju. |
|
Sorry, fixing that build now |
|
Obviously I've let the "matrix" test configuration rot -- the tests all passed in the build, but the test matrix that runs the tests on all the different OSes is broken because the workflow is using outdated tasks. I'm happy with this change, and don't see any reason I need to validate this particular change on every OS. I'm going to merge this, but based on the bit rot, I suspect we haven't set up automatic publishing for this yet ;) |
|
@Jaykul so do I understand it correctly that the automatic publishing is required for getting it into PowershellGallery for instance? |
2 participants
Fixes #131
This type issue was introduced since Pwsh 7.5.0 is based on .Net 9.
This solution is to type cast the variable and align it to be the same type.
For more details, open the Copilot Workspace session.