Feat: debug page for failed replication items in the queue #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fuziontech
commented
Jan 9, 2025
•
fuziontech
commented
- docker working for frontend dev
- feat: add a view for failed replication items
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: housewatch/clickhouse/client.py
Did you find this useful? React with a 👍 or 👎 |
Daesgar
approved these changes
Jan 10, 2025
| fetchClusters() | ||
| }, []) | ||
|
|
||
| const columns: ColumnType<ReplicationQueueItem>[] = [ |
There was a problem hiding this comment.
Could we also retrieve the last_exception_time? It's useful to compare the time the exception happened with the last_attempt time. Also, having the source_replica gives a hint of which host could be the source of the issue. 🕵️
Comment on lines
+62
to
+95
| def get_replication_queues(cluster): | ||
| nodes = get_all_replica_hosts(cluster) | ||
| for node in nodes: | ||
| yield get_replication_queue(node) | ||
|
|
||
|
|
||
| def get_replication_queue(node): | ||
| QUERY = """ | ||
| SELECT | ||
| database, | ||
| table, | ||
| replica_name, | ||
| position, | ||
| node_name, | ||
| type, | ||
| create_time, | ||
| required_quorum, | ||
| source_replica, | ||
| new_part_name, | ||
| parts_to_merge, | ||
| is_detach, | ||
| is_currently_executing, | ||
| num_tries, | ||
| last_exception, | ||
| last_attempt_time, | ||
| last_postpone_time, | ||
| postpone_reason, | ||
| merge_type | ||
| FROM system.replication_queue | ||
| WHERE last_exception != '' or postpone_reason != '' | ||
| ORDER BY create_time desc | ||
| LIMIT 100 | ||
| """ | ||
| return run_query(QUERY, node=node) |
There was a problem hiding this comment.
Why this instead of a clusterAllReplicas? If it's because some replica could be unavailable, we could use this setting in the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.