This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Fix tests by :any-ing catch errors #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
reviewed
Sep 6, 2021
There was a problem hiding this comment.
Good catch, we saw these failures with @yakkomajuri during the hackathon as well, but didn't have time to investigate. This is a valid hotfix.
However this should also not been a problem with CI, because CI should be using tsc from package.json, not what the GH Actions runner has globally. That part of the problem is fixed by #560.
Both this and that PR get rid of the errors.
|
Yes lets close this in favour of #560 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There was a change in typescript that means all catch error are type 'unkown' microsoft/TypeScript#20024
Checklist