chore: support to session replay #123
Conversation
| sessionReplay = it | ||
| } | ||
|
|
||
| this.sessionReplayConfig.captureLogcat = false |
There was a problem hiding this comment.
flutter has its own logging system, so no need to watch logcat
| val id = call.argument<Int>("id") ?: 1 | ||
| val x = call.argument<Int>("x") ?: 0 | ||
| val y = call.argument<Int>("y") ?: 0 |
There was a problem hiding this comment.
its ok to have a fallback here but it should never be the case anyway, x and y are always 0, and the id is ok to be 1
There was a problem hiding this comment.
what is really important is imageBytes
marandaneto
changed the title
| @@ -1,2 +1,3 @@ | |||
| org.gradle.jvmargs=-Xmx4G | |||
| android.useAndroidX=true | |||
| android.suppressUnsupportedCompileSdk=34 | |||
There was a problem hiding this comment.
needed for latest versions and we want to keep back compatibility so not bumping the sample
| @@ -1,7 +1,7 @@ | |||
| import UIKit | |||
| import Flutter | |||
|
|
|||
| @UIApplicationMain | |||
| @main | |||
There was a problem hiding this comment.
this is new but its the sample so its ok
| properties: properties, | ||
| ); | ||
| }) { | ||
| _currentScreen = screenName; |
There was a problem hiding this comment.
regression introduced here during refactoring https://github.com/PostHog/posthog-flutter/pull/117/files#diff-76c6e9a0e4d6150266a5008a193f88cea761a5620afecce9ba9ed7839aeb32c1
|
@pauldambra @ioannisj ready for review =) |
💡 Motivation and Context
Closes #69
Continues #116
Depends on PostHog/posthog-ios#266
💚 How did you test it?
Running sample on Android
📝 Checklist