Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change screenshots debouncing approach to throttling #131

Merged
merged 7 commits into from
Dec 13, 2024
Merged

chore: change screenshots debouncing approach to throttling #131

merged 7 commits into from
Dec 13, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Dec 12, 2024 •
edited
Loading

💡 Motivation and Context

Closes #130

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team December 12, 2024 15:00
@marandaneto marandaneto marked this pull request as ready for review December 12, 2024 15:00
@marandaneto marandaneto mentioned this pull request Dec 12, 2024
Closed
marandaneto
marandaneto commented Dec 12, 2024
View reviewed changes
lib/src/posthog_config.dart Outdated
@@ -67,17 +67,25 @@ class PostHogSessionReplayConfig {
/// Default: true.
var maskAllImages = true;

/// Note: Deprecated in favor of [throttleDelay] from v4.8.0.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not removing this var to avoid compilation issues

ioannisj
ioannisj approved these changes Dec 12, 2024
View reviewed changes
Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments. LG

lib/src/posthog_config.dart Show resolved Hide resolved
lib/src/posthog_widget_widget.dart Show resolved Hide resolved
@marandaneto marandaneto merged commit fe94dc0 into main Dec 13, 2024
3 checks passed
@marandaneto marandaneto deleted the chore/throttleDelay branch December 13, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannisj ioannisj ioannisj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debouncer in session recording causes frames to be skipped
2 participants
@marandaneto @ioannisj