Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App opened event respects the life cycle config #102

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 8, 2024

💡 Motivation and Context

App opened event was being captured even though the lifecycle config was deactivated.
All the other events were already guarded by the lifecycle config.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review February 8, 2024 12:12
@marandaneto marandaneto requested a review from a team February 8, 2024 12:12
@marandaneto marandaneto merged commit e8a13d5 into main Feb 8, 2024
12 checks passed
@marandaneto marandaneto deleted the fix/captureApplicationLifecycleEvents-app-opened branch February 8, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants