Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ISO8601 formatter to always use the 24h format #106

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #103

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto
Copy link
Member Author

@bddq are you able to test from a branch?
the format was HH already and not hh so I believe it could be the default timezone and locale.
I cannot change my emulator to 12h only for some reason, the settings are blocked.

Copy link
Contributor

@bddq bddq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locale did the trick. It's working as expected on my side with a 12-hour time format.

@marandaneto marandaneto mentioned this pull request Feb 9, 2024
@marandaneto marandaneto marked this pull request as ready for review February 9, 2024 12:50
@marandaneto marandaneto merged commit 1e4f5e4 into main Feb 9, 2024
7 checks passed
@marandaneto marandaneto deleted the fix/clock-12h-to-24h-always branch February 9, 2024 12:50
Copy link

github-actions bot commented Feb 9, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- fix ISO8601 formatter to always use the 24h format ([#106](https://github.com/PostHog/posthog-ios/pull/106))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3302e97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch HTTP 400
2 participants